Skip to content

[Coordinator throttling] Changes in DiscoveryNodeManager to consume the worker load metrics#25688

Open
prashantgolash wants to merge 1 commit into
prestodb:masterfrom
prashantgolash:export-D76911853
Open

[Coordinator throttling] Changes in DiscoveryNodeManager to consume the worker load metrics#25688
prashantgolash wants to merge 1 commit into
prestodb:masterfrom
prashantgolash:export-D76911853

Conversation

@prashantgolash

@prashantgolash prashantgolash commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Summary:
Changes for DiscoveryManager to use the new end point i.e /v1/info/stats

Logic

  1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats.
  2. Consuming NodeState from the new structure
  3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

In the follow up PRs we can deprecate /v1/info/state endpoint we can rid of RemoteNodeState and HttpRemoteNodeState

Differential Revision: D76911853

@prashantgolash prashantgolash requested review from a team as code owners August 5, 2025 06:41
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Aug 5, 2025
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

@prashantgolash prashantgolash changed the title Changes in DiscoveryNodeManager to consume the worker load [Coordinator throttling] Changes in DiscoveryNodeManager to consume the worker load metrics Aug 5, 2025
prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…he worker load metrics (prestodb#25688)

Summary:
Pull Request resolved: prestodb#25688

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats.
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 5, 2025

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: prashantgolash / name: PRASHANT GOLASH (9bc96e3)

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…he worker load metrics (prestodb#25688)

Summary:
Pull Request resolved: prestodb#25688

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats.
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…he worker load metrics (prestodb#25688)

Summary:
Pull Request resolved: prestodb#25688

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats.
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Aug 5, 2025
…he worker load metrics (prestodb#25688)

Summary:
Pull Request resolved: prestodb#25688

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats.
2. Consuming NodeState from the new structure
3. Exposing a function to fetch worker load metrics which we will be used to make scheduling decisions

(In future we can clean up the code fro NodeState fetching)

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

1 similar comment
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:
Pull Request resolved: prestodb#25688

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats.
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

prashantgolash added a commit to prashantgolash/presto that referenced this pull request Sep 8, 2025
…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

1 similar comment
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

…he worker load metrics (prestodb#25688)

Summary:

Changes for DiscoveryManager to use the new end point added in the underlying diff

Logic
1. Boiler plate code for fetching / refreshing the node stats similar to NodeState -> NodeStats. 
2. Consuming NodeState from the new response

Once we clean up the NodeState endpoint, we can get rid of `RemoteNodeState` and `HttpRemoteNodeState`.

Differential Revision: D76911853
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

This pull request was exported from Phabricator. Differential Revision: D76911853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants