[Coordinator throttling] Endpoint on Java worker reporting nodestats#25687
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load as going forward we will be focussing on cpp worker only Differential Revision: D79471792
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load as going forward we will be focussing on cpp worker only Differential Revision: D79471792
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load as going forward we will be focussing on cpp worker only Differential Revision: D79471792
37962f3 to
28da34b
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
…todb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
28da34b to
9ba5817
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
9ba5817 to
56bb894
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
…todb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
…todb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
56bb894 to
8d16202
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
…todb#25687) Summary: Pull Request resolved: prestodb#25687 Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
8d16202 to
77d09ac
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
…todb#25687) Summary: Pull Request resolved: prestodb#25687 Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
77d09ac to
693084c
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 5, 2025
…todb#25687) Summary: Pull Request resolved: prestodb#25687 Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
693084c to
a70d3fa
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 11, 2025
…restodb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
436110a to
6031d50
Compare
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 11, 2025
…restodb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 11, 2025
…restodb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 11, 2025
…restodb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 11, 2025
…restodb#25687) Summary: Pull Request resolved: prestodb#25687 Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
6031d50 to
be64523
Compare
prashantgolash
pushed a commit
to prashantgolash/presto
that referenced
this pull request
Aug 11, 2025
…restodb#25687) Summary: Pull Request resolved: prestodb#25687 Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
prashantgolash
added a commit
to prashantgolash/presto
that referenced
this pull request
Aug 27, 2025
…restodb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
be64523 to
63e7e11
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
tdcmeehan
reviewed
Aug 27, 2025
tdcmeehan
left a comment
Contributor
There was a problem hiding this comment.
LGTM % how we indicate presence of the stats.
…ad metrics (prestodb#25686) Summary: **Context:** We want to consider worker load metrics to make scheduling decision from coordinator. Currently in single coordinator setup, it invokes /v1/info/state to get worker's state. **Approach:** Added a new end point to get nodeStats. The idea is that we would replace "/v1/info/state" -> "/v1/info/nodestate" which will include nodeState + <worker load metrics>. This will help coordinator making scheduling decisions Reviewed By: spershin Differential Revision: D76357677
…restodb#25687) Summary: Similar to cpp worker added the endpoint for java. We won't be using the worker-load on Java workers Differential Revision: D79471792
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D79471792 |
tdcmeehan
approved these changes
Aug 27, 2025
This was referenced Sep 11, 2025
This was referenced Sep 24, 2025
17 tasks
17 tasks
Contributor
|
@prashantgolash Can you please add/provide release notes for this PR? This adds a new endpoint so we would like to include it in the release notes. |
Contributor
Author
Sure I will add. Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Similar to cpp worker added the endpoint for java.
We won't be using the worker-load as going forward we will be focussing on cpp worker only
Differential Revision: D79471792