[native] Enable getTaskInfo and deleteTask#25535
Merged
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D77463142 |
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D77463142 |
gggrace14
reviewed
Jul 15, 2025
| message->getQueryParam(protocol::PRESTO_ABORT_TASK_URL_PARAM) == "true"; | ||
| } | ||
| bool summarize = message->hasQueryParam("summarize"); | ||
| auto& headers = message->getHeaders(); |
gggrace14
reviewed
Jul 15, 2025
| auto maxWait = getMaxWait(message); | ||
| bool summarize = message->hasQueryParam("summarize"); | ||
|
|
||
| auto& headers = message->getHeaders(); |
Contributor
Author
There was a problem hiding this comment.
thanks for the review! I will make this change in a followup PR.
gggrace14
approved these changes
Jul 15, 2025
This was referenced Jul 24, 2025
6 tasks
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 2, 2025
## Description - Native changes to enable thrift for getTaskInfo and deleteTask endpoints - Depends on prestodb#25464 ## Motivation and Context prestodb/rfcs#38 ## Test Plan Build package and test in verifier: 230498 ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description - Native changes to enable thrift for getTaskInfo and deleteTask endpoints - Depends on prestodb#25464 ## Motivation and Context prestodb/rfcs#38 ## Test Plan Build package and test in verifier: 230498 ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description - Native changes to enable thrift for getTaskInfo and deleteTask endpoints - Depends on prestodb#25464 ## Motivation and Context prestodb/rfcs#38 ## Test Plan Build package and test in verifier: 230498 ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description - Native changes to enable thrift for getTaskInfo and deleteTask endpoints - Depends on prestodb#25464 ## Motivation and Context prestodb/rfcs#38 ## Test Plan Build package and test in verifier: 230498 ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description - Native changes to enable thrift for getTaskInfo and deleteTask endpoints - Depends on prestodb#25464 ## Motivation and Context prestodb/rfcs#38 ## Test Plan Build package and test in verifier: 230498 ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description - Native changes to enable thrift for getTaskInfo and deleteTask endpoints - Depends on prestodb#25464 ## Motivation and Context prestodb/rfcs#38 ## Test Plan Build package and test in verifier: 230498 ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description - Native changes to enable thrift for getTaskInfo and deleteTask endpoints - Depends on prestodb#25464 ## Motivation and Context prestodb/rfcs#38 ## Test Plan Build package and test in verifier: 230498 ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
prestodb/rfcs#38
Test Plan
Build package and test in verifier: 230498
Release Notes
Please follow release notes guidelines and fill in the release notes below.