added wrapper for concept names#155
Merged
ncfrey merged 2 commits intoprescient-design:mainfrom Jul 25, 2025
Merged
Conversation
ncfrey
reviewed
Jul 24, 2025
| json.dump(self._concepts_name, f) | ||
|
|
||
| @property | ||
| def concept_names(self): |
Contributor
There was a problem hiding this comment.
can you add a unit test to confirm that this returns the expected concept names? thanks!
Contributor
Author
There was a problem hiding this comment.
done! Let me know if it looks good :)
ncfrey
approved these changes
Jul 25, 2025
12 tasks
Collaborator
|
tests are failing on main :( |
Contributor
Author
|
hey @karinazad, added a fix for the tests failing on main in #156, it was a typo on my end, sorry about that. Let me know if it looks good! |
taylormjs
pushed a commit
that referenced
this pull request
Jul 31, 2025
* added wrapper for concept names * Add unit test for concept_names property
taylormjs
pushed a commit
that referenced
this pull request
Aug 1, 2025
* added wrapper for concept names * Add unit test for concept_names property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a public concept_names property to the LobsterCBMPMLM class to expose concept names that were previously only accessible as a private attribute. This resolves issue #154.
Type of Change
Testing
Checklist