feat: Add constraints to limit dependency versions#5603
Merged
pavelzw merged 19 commits intoprefix-dev:mainfrom Mar 17, 2026
Merged
feat: Add constraints to limit dependency versions#5603pavelzw merged 19 commits intoprefix-dev:mainfrom
constraints to limit dependency versions#5603pavelzw merged 19 commits intoprefix-dev:mainfrom
Conversation
delsner
commented
Mar 9, 2026
| .constraints | ||
| .map(|c| { | ||
| c.value | ||
| .into_inner(pixi_build_enabled) |
Contributor
Author
There was a problem hiding this comment.
@pavelzw not so sure about this one, do you think it makes sense?
Collaborator
There was a problem hiding this comment.
looks okay to me but maybe @Hofer-Julian or @ruben-arts could take another look?
delsner
commented
Mar 9, 2026
pavelzw
reviewed
Mar 10, 2026
| .constraints | ||
| .map(|c| { | ||
| c.value | ||
| .into_inner(pixi_build_enabled) |
Collaborator
There was a problem hiding this comment.
looks okay to me but maybe @Hofer-Julian or @ruben-arts could take another look?
- Remove .cargo-tmp/ from .gitignore (dev artifact) - Fix doc comment comma in features_ext.rs - Raise error for source specs in [constraints] instead of silently dropping - Simplify satisfiability check: use by_name() and nameless_spec.matches() directly
…cate tests - Raise a parse-time error when a source spec appears in [constraints] with a span-annotated miette diagnostic (regardless of pixi-build mode) - Remove three constraint tests from target.rs that duplicated tests already present in manifests/workspace.rs
Instead of silently continuing when a source spec appears in [constraints] during the lock file satisfiability check, raise a PlatformUnsat error. This is defence-in-depth — parse-time validation already blocks source specs in constraints, but an explicit error is clearer than a silent skip.
pavelzw
approved these changes
Mar 11, 2026
ruben-arts
reviewed
Mar 16, 2026
Contributor
ruben-arts
left a comment
There was a problem hiding this comment.
This looks good, only one documentation improvement requested. Thanks for the work!
Some follow-up PRs I would love to see are:
- Adding it to
pixi list -xto see what was constraint - Adding it to the
clie.g.pixi add --constraint - Adding it to the pypi interface.
ruben-arts
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3278
How Has This Been Tested?
AI Disclosure
Tools: Claude
Checklist:
schema/model.py.