fix: change TlsRootCerts to select All by default#5244
fix: change TlsRootCerts to select All by default#5244tdejager merged 5 commits intoprefix-dev:mainfrom
TlsRootCerts to select All by default#5244Conversation
|
I dont understand, did we previously also always load the native certificates? There is some overhead using the native certificates, so if we dont need to load them by default thats better I think. |
Apparently: https://discord.com/channels/1082332781146800168/1458197225422196868, something regressed, I also thought we did not load them by default. |
|
Yes, we seem to have been loading native certs for both conda and pypi package installations prior to 0.61.0 / #5013. I'm kinda confused as to what that feature changed now. |
|
That change was mainly made so that we could also have uv load native certificates, with like a way of sanely setting the settings because we allow native-tls builds while uv does not. |
|
Reading: https://github.com/seanmonstar/reqwest/blob/8b8fdd2552ad645c7e9dd494930b3e95e2aedef2/src/async_impl/client.rs#L227C1-L228C49 (this sets the And (same file): Looking at Cargo.toml https://github.com/seanmonstar/reqwest/blob/8b8fdd2552ad645c7e9dd494930b3e95e2aedef2/Cargo.toml#L52: rustls-tls-native-roots = ["rustls-tls-native-roots-no-provider", "__rustls-ring"]And we were setting in pixi pixi/crates/pixi_utils/Cargo.toml Line 19 in b3de9f4 rustls-tls = [
"reqwest/rustls-tls",
"reqwest/rustls-tls-native-roots", # <----
"rattler_networking/rustls-tls",
]I think we were loading native indeed, so I think this fix is necessary. |
|
Thanks for the deep dive! |
PR #5244 changed the default TLS root certificates from Webpki to All. This commit updates the test to reflect this change.
Description
This sets the
TlsRootCerttoAllby default. I think this should be the default to cover as much bases as possible, but maybe this is insecure, I'm not super sure. Ben Moss was reporting problems where he did not have them before and needs the native certificate store as well it seems.How Has This Been Tested?
I hope Ben Moss, could give this a go.