fix: include variants when calculating cache key#5167
Merged
baszalmstra merged 9 commits intoprefix-dev:mainfrom Dec 19, 2025
Merged
Conversation
baszalmstra
requested changes
Dec 19, 2025
Contributor
baszalmstra
left a comment
There was a problem hiding this comment.
Every test does rhis now. Since you only need it for one test, best to create a mockdatabase specifically for that.
Contributor
|
With this I mean the materialization of sdl2 |
baszalmstra
requested changes
Dec 19, 2025
| fs_err::create_dir_all(&info_dir)?; | ||
|
|
||
| // Write index.json | ||
| let index_json_content = serde_json::to_string_pretty(index_json)?; |
Contributor
There was a problem hiding this comment.
When you create the outputs from conda_outputs you augment the information from the index.json. That should also happen here, otherwise they dont represent the same thing.
|
|
||
| /// The specific variant values for this build. Different variants result | ||
| /// in different cache keys to ensure they are cached separately. | ||
| pub variants: Option<BTreeMap<String, VariantValue>>, |
Contributor
There was a problem hiding this comment.
I think this should not be an option. Variants are always present.
baszalmstra
reviewed
Dec 19, 2025
crates/pixi/tests/integration_rust/develop_dependencies_tests.rs
Outdated
Show resolved
Hide resolved
baszalmstra
reviewed
Dec 19, 2025
Contributor
Indicates that you return different data from |
baszalmstra
approved these changes
Dec 19, 2025
ruben-arts
pushed a commit
to ruben-arts/pixi
that referenced
this pull request
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem was that we did not take into account variants when searching for a cached source build, so we would pick up another one and omit the building part.
Fixes: #4139
How Has This Been Tested?
AI Disclosure
Tools: Claude
Checklist:
schema/model.py.