fix: Preserve symlinked manifest paths#4912
Merged
baszalmstra merged 4 commits intoprefix-dev:mainfrom Nov 21, 2025
Merged
Conversation
claydugo
commented
Nov 11, 2025
baszalmstra
approved these changes
Nov 21, 2025
Contributor
|
Thanks! |
claydugo
added a commit
to claydugo/pixi
that referenced
this pull request
Dec 4, 2025
…mlinks The fix in prefix-dev#4912 for symlinked manifest paths was incomplete. While ManifestProvenance::absolute_path() correctly preserves symlinks by only canonicalizing the parent directory, the Workspace::from_manifests() function was re-canonicalizing the entire manifest path, which resolved the symlink and caused the .pixi directory to be created in the wrong location. This change uses absolute_path() instead of dunce::canonicalize() when computing the workspace root, ensuring that symlinked pixi.toml files work correctly in dotfiles workflows. Fixes the remaining issue from prefix-dev#4907.
claydugo
added a commit
to claydugo/pixi
that referenced
this pull request
Dec 4, 2025
…mlinks The fix in prefix-dev#4912 for symlinked manifest paths was incomplete. While ManifestProvenance::absolute_path() correctly preserves symlinks by only canonicalizing the parent directory, the Workspace::from_manifests() function was re-canonicalizing the entire manifest path, which resolved the symlink and caused the .pixi directory to be created in the wrong location. This change uses absolute_path() instead of dunce::canonicalize() when computing the workspace root, ensuring that symlinked pixi.toml files work correctly in dotfiles workflows. Fixes the remaining issue from prefix-dev#4907. fixup
claydugo
added a commit
to claydugo/pixi
that referenced
this pull request
Dec 4, 2025
…mlinks The fix in prefix-dev#4912 for symlinked manifest paths was incomplete. While ManifestProvenance::absolute_path() correctly preserves symlinks by only canonicalizing the parent directory, the Workspace::from_manifests() function was re-canonicalizing the entire manifest path, which resolved the symlink and caused the .pixi directory to be created in the wrong location. This change uses absolute_path() instead of dunce::canonicalize() when computing the workspace root, ensuring that symlinked pixi.toml files work correctly in dotfiles workflows. Fixes the remaining issue from prefix-dev#4907. fixup lint
8 tasks
2 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where pixi resolves symlinked
pixi.tomlfiles to their real location, causing the.pixi/directory to be created relative to the symlink target instead of the symlink itself. This broke common dotfiles management workflows where users symlink config files from a git repository to their home directory.Fixes #4907
How Has This Been Tested?
Test was added to
crates/pixi_manifest/src/manifests/provenance.rsand I tested the described workflow locally with the generated binary.AI Disclosure
Tools: Claude Code with body of issue I wrote
Checklist: