fix: incorrect python version was used in some parts of the solve#2481
Merged
ruben-arts merged 10 commits intoprefix-dev:mainfrom Nov 15, 2024
Merged
Conversation
ruben-arts
approved these changes
Nov 14, 2024
Contributor
ruben-arts
left a comment
There was a problem hiding this comment.
Appart from the warning, this looks good to me!
We should quickly get this in a release.
Co-authored-by: Ruben Arts <ruben@prefix.dev>
hameerabbasi
suggested changes
Nov 14, 2024
Contributor
hameerabbasi
left a comment
There was a problem hiding this comment.
Typo, plus maybe we should add tests?
Contributor
|
Looks good! I think we can add this example in our test_integration to make sure that we will not introduce this regression again |
Co-authored-by: Hameer Abbasi <2190658+hameerabbasi@users.noreply.github.com>
… dependencies group (prefix-dev#2459) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ix-dev#2417) Co-authored-by: Ruben Arts <ruben.arts@hotmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the over-use of the
Intepreterin the solve, it was using it incorrectly in some parts of the resolution. This would result in weird behavior, like getting the incorrect wheels from the registry and not being to able to match them with the wheel tags, for example.Discovered because of: #771 (comment). This should now work.
Test
To test you can try:
Which did not work before and now it does.