Add retry logic to support temporary redis cluster failure (\Predis\C… #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection\Aggregate\RedisCluster)
82b1826 to
6f6c785
Compare
Member
|
No worries. @nrk Any input on this? |
Contributor
Author
|
Hi, |
1 similar comment
Contributor
Author
|
Hi, |
Member
|
@digital2real Danielle seems MIA. Can you add unit tests for your changes that cover all new scenarios? |
tillkruss
requested changes
Feb 18, 2022
| } | ||
|
|
||
| ++$retries; | ||
| sleep(2^$retries); |
| { | ||
| $failure = false; | ||
|
|
||
| $retries= 0 ; |
| $connection->disconnect(); | ||
|
|
||
| $this->remove($connection); | ||
| if (is_a($response, '\\Predis\\Response\\Error')){ |
| throw new ServerException($message) ; | ||
| } | ||
| } | ||
| } catch (ConnectionException|ServerException $exception) { |
Member
There was a problem hiding this comment.
I don't think this syntax is compatible with olde PHP versions.
Member
|
Feel free to re-submit to the 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are trying to complete the retry logic in order to increase the tolerance to a temporary unavailability of a redis cluster.
(Sorry for previous PR #731 on main)