Skip to content

Added OSS cluster tests #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vladvildanov merged 3 commits into from
Dec 26, 2023
Merged

Added OSS cluster tests #1421

vladvildanov merged 3 commits into from
Dec 26, 2023

Conversation

@vladvildanov
Copy link
Contributor

@vladvildanov vladvildanov commented Dec 20, 2023

Tests to prove that Relay connection can be used within cluster(aggregate) connection

@vladvildanov
Copy link
Contributor Author

vladvildanov commented Dec 20, 2023

@tillkruss Do you think we need more cluster test cases?

vladvildanov
vladvildanov commented Dec 20, 2023
View reviewed changes
@tillkruss
Copy link
Member

tillkruss commented Dec 20, 2023

@tillkruss Do you think we need more cluster test cases?

No, I think having minimal tests for Cluster is fine, it's an edge-case IMO.

@vladvildanov vladvildanov merged commit c5435f5 into predis:feature/relay-improvements Dec 26, 2023
tillkruss added a commit that referenced this pull request Dec 28, 2023
@vladvildanov @tillkruss
Improved Relay integration (#1423)
d56e327 
* Fixed Relay objects structure (#1419)
* Added OSS cluster tests (#1421)

---------

Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tillkruss tillkruss tillkruss approved these changes

Assignees

No one assigned

Labels

maintenance

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladvildanov @tillkruss