Fix a few issues (group relay-todo) #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
reviewed
Feb 26, 2023
tillkruss
added a commit
that referenced
this pull request
Feb 26, 2023
* fix ZUNION_Test * code style * fix ZUNIONSTORE_Test * fix ZPOPMIN_Test * fix ZPOPMAX_Test * fix "undefined array key 0" round one * fix "undefined array key 0" round two * fix HRANDFIELD_Test * Fixes for redis 6 * use uniform check * simplify * simplify * simplify * Update ZRANGE_Test.php * Update ZPOPMAX_Test.php * Update ZPOPMIN_Test.php * Update LCS_Test.php * uniform * Update HGETALL_Test.php * Update WithScores.php * revert --------- Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
tillkruss
added a commit
that referenced
this pull request
Feb 26, 2023
* fix ZUNION_Test * code style * fix ZUNIONSTORE_Test * fix ZPOPMIN_Test * fix ZPOPMAX_Test * fix "undefined array key 0" round one * fix "undefined array key 0" round two * fix HRANDFIELD_Test * Fixes for redis 6 * use uniform check * simplify * simplify * simplify * Update ZRANGE_Test.php * Update ZPOPMAX_Test.php * Update ZPOPMIN_Test.php * Update LCS_Test.php * uniform * Update HGETALL_Test.php * Update WithScores.php * revert --------- Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix a few bugs, currently the errors went down from 55 to 19 using Redis 7 and to 3 using Redis 6)
@tillkruss most of what is left related to relay like
Wrong number of arguments for 'MOVE' command (argc: 2, arity: 2) (RELAY_ERR_OTHER; commands.c:7344)so any feedback on how to deal with that would be great.if you think the PR is ready, feel free to merge.