Skip to content

Conversation

@tillkruss
Copy link
Member

@tillkruss tillkruss commented Feb 21, 2023

Fix return type.

also the name of this method 😬
@coveralls
Copy link

coveralls commented Feb 21, 2023

Coverage Status

Coverage: 87.458% (+0.006%) from 87.452% when pulling 87d5dd0 on fix-return-type into 8ef75ba on v2.x.

@tillkruss tillkruss marked this pull request as ready for review February 21, 2023 16:30
@tillkruss tillkruss merged commit 26c6252 into v2.x Feb 21, 2023
@tillkruss tillkruss deleted the fix-return-type branch February 21, 2023 16:30
vladvildanov added a commit that referenced this pull request Apr 3, 2023
* Added support for new arguments for BITPOS, BITCOUNT commands (#1045)

* Added support for new arguments for EXPIRE, EXPIREAT commands (#1046)

* Extended core support by implementing SORT_RO command (#1044)

* Added support for SORT_RO command

* Codestyle fixes

* Added command description

---------

Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>

* fix deprecated call

* Added support for container commands (#1049)

* Added support for container commands FUNCTION LOAD, FUNCTION DELETE and FCALL

* Changed ContainerInterface and AbstractContainer

* Re-implement logic of abstract methods

---------

Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>

* Added stream commands to KeyPrefixProcessor (#1051)

Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>

* Fix return type of ReplicationInterface::getSlaves (#1111)

* Codestyle fixes

* Changed return annotation

* Add option for disabling reads to slaves in replication topologies (#1168)

* Add option for disabling reads to slaves in replication topologies

(cherry picked from commit e132c31)

* remove empty line

---------

Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>

* match `MasterSlaveReplication` (#1175)

* match `MasterSlaveReplication`

also the name of this method 😬

* Update SentinelReplication.php

* Added CODEOWNERS file (#1181)

* Added CODEOWNERS file

* Update CODEOWNERS

* Applied whole Redis commands path as @vladvildanov codeowner

* Set @predis/team as Redis commands codeowners

* Update CODEOWNERS

---------

Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>

* Deprecate webdis and phpiredis (#1179)

* Deprecate webdis and phpiredis

* remove space

* tag v2.1.2

* Extended core support by implementing FCALL_RO command (#1191)

* typo

* Extended core support by implementing ACL SETUSER, GETUSER, DRYRUN (#1193)

* Added support for ACL GETUSER, SETUSER, DRYRUN commands

* Change test to support Redis > 6.0.0

* Removed selectors check

* Add missing stream key prefixes (#1230)

* Added missing stream key prefixes

* Tested stream command key prefixing

* Codestyle fix

* Changed idx name for different index types

---------

Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>
Co-authored-by: Till Krüss <till@kruss.io>
Co-authored-by: Stephan <glaubinix@users.noreply.github.com>
Co-authored-by: David Bomba <turbo124@gmail.com>
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
Co-authored-by: Jess Archer <jess@jessarcher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants