Conversation
And add version tags, starting at version 1. E.g. one can pull "prebuild/alpine:1" or (same as before) "prebuild/alpine:latest".
vweevers
added a commit
to prebuild/prebuildify-cross
that referenced
this pull request
Jul 31, 2021
Depends on prebuild/docker-images#19. Effectively fixes a critical bug (prebuild/docker-images#17) for dockcross-based images. Those are: - `linux-armv6` - `linux-armv7` - `linux-arm64` - `android-armv7` - `android-arm64` Also pins image versions (to version 1) by default, which is now possible because the images are tagged with version numbers in addition to the `latest` tag. Image descriptions have moved to the prebuild/docker-images repository.
This was referenced Jul 31, 2021
vweevers
added a commit
to prebuild/prebuildify-cross
that referenced
this pull request
Aug 1, 2021
Depends on prebuild/docker-images#19. Effectively fixes a critical bug (prebuild/docker-images#17) for dockcross-based images. Those are: - `linux-armv6` - `linux-armv7` - `linux-arm64` - `android-armv7` - `android-arm64` Also pins image versions (to version 1) by default, which is now possible because the images are tagged with version numbers in addition to the `latest` tag. Image descriptions have moved to the prebuild/docker-images repository. Uses a temporary fork of the docker-pull npm package in order to include mafintosh/docker-pull#2.
Member
|
@vweevers Super nice! Sorry for not getting back in a timely fashion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of Docker Hub Autobuild (#16), use a GitHub Actions workflow that is triggered by a git tag and publishes images to the GitHub Container Registry. Making image changes more explicit, though further work will be required to fully prevent accidental breaking changes like #17.
In this new workflow, each image gets version tags sourced from the git tag, starting at version 1.0.0. E.g. one can pull
prebuild/alpine:1,prebuild/alpine:1.0,prebuild/alpine:1.0.0or (same as before)prebuild/alpine:latest. This will allow us to make breaking changes like #15 and #10.