Debug: limit "object as children" error to elements#3801
Merged
Conversation
This should fix preactjs/preact-render-to-string#254 without incurring the performance overhead of converting primitives in JSX text positions to VNodes.
|
Size Change: -17 B (0%) Total Size: 52.9 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Nov 15, 2022
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
Not sure why I went the other way. Agree that this is a better approach 👍
developit
commented
Nov 15, 2022
Member
Author
|
Alright, I just manually confirmed that this change addresses preactjs/preact-render-to-string#254. Will open a PR there. |
developit
added a commit
to preactjs/preact-render-to-string
that referenced
this pull request
Nov 15, 2022
JoviDeCroock
pushed a commit
to preactjs/preact-render-to-string
that referenced
this pull request
Feb 25, 2023
JoviDeCroock
pushed a commit
to preactjs/preact-render-to-string
that referenced
this pull request
Feb 25, 2023
JoviDeCroock
added a commit
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix preactjs/preact-render-to-string#254 without incurring the performance overhead of converting primitives in JSX text positions to VNodes.
If this works, we can remove these lines from render-to-string.