Preserve state when using placeholders#2295
Merged
Merged
Conversation
|
Size Change: -6 B (0%) Total Size: 38.2 kB
ℹ️ View Unchanged
|
andrewiggins
commented
Jan 31, 2020
| newVNode._children = toChildArray( | ||
| isTopLevelFragment ? tmp.props.children : tmp | ||
| ); | ||
| newVNode._children = isTopLevelFragment ? tmp.props.children : tmp; |
Member
Author
There was a problem hiding this comment.
Should this property be renamed to _renderResult since it isn't guaranteed to be an array until after diffChildren is complete? I vaguely remember this confusing people before. I was hesitant to do this immediately cuz it adds yet another property to VNode and this one is particularly short lived (it's just a way to pass the result into diffChildren)
| }); | ||
| }); | ||
|
|
||
| it('should correctly render when sCU component has null children', () => { |
Member
Author
There was a problem hiding this comment.
This test was in this branch from a while ago. Not sure what it was trying to do but figured it can't hurt 🤷♂
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Feb 3, 2020
* Add test with sCU and null children * Add state-perserving placeholder test * Remove toChildArray call on render result (-1 B)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test and fix a bug where
null,false, andtruewere removed from the render result before going intodiffChildren. CallingtoChildArraywithout a callback removes the values mentioned above, which we were doing on the result of render before going intodiffChildren.