Fix Children.map not flattening result#2287
Merged
Merged
Conversation
|
Size Change: +58 B (0%) Total Size: 38.2 kB
ℹ️ View Unchanged
|
78344d9 to
cd3581a
Compare
JoviDeCroock
approved these changes
Jan 28, 2020
Member
|
Could save a byte (and a |
Member
Author
|
@sventschui Super awesome, that is a lot better 💯 I had a hunch that the current solution wasn't as optimal as it should be 👍 |
JoviDeCroock
approved these changes
Jan 28, 2020
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Feb 3, 2020
Fix Children.map not flattening result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just checked against the implementation in React and they flatten the result of
Children.map. We didn't do that which lead to anarrayof children being passed toisValidElement. Becausearraysare not valid children they were filtered out.Fixes #2286 .