Skip to content

Try out new node submodule exports#2283

Merged
marvinhagemeister merged 3 commits into
masterfrom
node-submodule-exports
Jan 27, 2020
Merged

Try out new node submodule exports#2283
marvinhagemeister merged 3 commits into
masterfrom
node-submodule-exports

Conversation

@JoviDeCroock

@JoviDeCroock JoviDeCroock commented Jan 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

resolves: #2282

@JoviDeCroock JoviDeCroock mentioned this pull request Jan 27, 2020
Closed
@github-actions

github-actions Bot commented Jan 27, 2020 •
edited
Loading

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 38.1 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 2.94 kB 0 B
compat/dist/compat.module.js 2.97 kB 0 B
compat/dist/compat.umd.js 2.99 kB 0 B
debug/dist/debug.js 3.08 kB 0 B
debug/dist/debug.module.js 3.07 kB 0 B
debug/dist/debug.umd.js 3.14 kB 0 B
devtools/dist/devtools.js 175 B 0 B
devtools/dist/devtools.module.js 185 B 0 B
devtools/dist/devtools.umd.js 252 B 0 B
dist/preact.js 3.69 kB 0 B
dist/preact.min.js 3.69 kB 0 B
dist/preact.module.js 3.71 kB 0 B
dist/preact.umd.js 3.75 kB 0 B
hooks/dist/hooks.js 1.06 kB 0 B
hooks/dist/hooks.module.js 1.08 kB 0 B
hooks/dist/hooks.umd.js 1.12 kB 0 B
test-utils/dist/testUtils.js 390 B 0 B
test-utils/dist/testUtils.module.js 392 B 0 B
test-utils/dist/testUtils.umd.js 469 B 0 B

compressed-size-action

@coveralls

coveralls commented Jan 27, 2020 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 99.807% when pulling f141a28 on node-submodule-exports into aca606a on master.

marvinhagemeister
marvinhagemeister reviewed Jan 27, 2020
View reviewed changes
Comment thread package.json
marvinhagemeister
marvinhagemeister approved these changes Jan 27, 2020
View reviewed changes

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome, thanks a bunch for the PR 👍 💯

@marvinhagemeister marvinhagemeister merged commit 8a9407d into master Jan 27, 2020
@marvinhagemeister marvinhagemeister deleted the node-submodule-exports branch January 27, 2020 19:42
@ForsakenHarmony

ForsakenHarmony commented Feb 2, 2020

Copy link
Copy Markdown
Member

Should we also add the root package?

Seems to be supported with the "." path if I understand it correctly

@JoviDeCroock

JoviDeCroock commented Feb 2, 2020

Copy link
Copy Markdown
Member Author

Good shout!

porfirioribeiro pushed a commit to porfirioribeiro/preact that referenced this pull request Feb 3, 2020
@marvinhagemeister @porfirioribeiro
Try out new node submodule exports (preactjs#2283)
49a3b4b 
Try out new node submodule exports
4cm4k1 added a commit to 4cm4k1/preact that referenced this pull request Feb 3, 2020
@4cm4k1
fix: resolves Node error about there being no ./compat/server modul…
2921f2a 
…e subpath (preactjs#2282, preactjs#2283)
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define Package Exports in package.json

4 participants

@JoviDeCroock @coveralls @ForsakenHarmony @marvinhagemeister