Skip to content

fix(useRef typedef): allow null initialValue#2281

Merged
JoviDeCroock merged 1 commit into
preactjs:masterfrom
armujahid:typedef-useRefAllowNull
Jan 26, 2020
Merged

fix(useRef typedef): allow null initialValue#2281
JoviDeCroock merged 1 commit into
preactjs:masterfrom
armujahid:typedef-useRefAllowNull

Conversation

@armujahid

Copy link
Copy Markdown
Contributor

Closes #2268

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.807% when pulling 097dae8 on armujahid:typedef-useRefAllowNull into cfaa1ca on preactjs:master.

@JoviDeCroock JoviDeCroock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for taking time out of your day to fix this up! Looks ready to merge to me

@JoviDeCroock JoviDeCroock merged commit a6cab5b into preactjs:master Jan 26, 2020
@pika-ci

pika-ci Bot commented Jan 26, 2020

Copy link
Copy Markdown

🚀 This PR has been merged! Once a new release is created, any changes will become available on npm. Until then, you can load and install it directly from the Pika CDN:

npm install https://cdn.pika.dev/preact/master
import * as pkg from 'https://cdn.pika.dev/preact/master';

porfirioribeiro pushed a commit to porfirioribeiro/preact that referenced this pull request Feb 3, 2020
@armujahid armujahid deleted the typedef-useRefAllowNull branch March 2, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should useRef's TypeScript declaration also allow it to be "null"?

3 participants