Skip to content

Fix both class and className being enumerable#2280

Merged
JoviDeCroock merged 2 commits into
masterfrom
classname-enumerable
Jan 26, 2020
Merged

Fix both class and className being enumerable#2280
JoviDeCroock merged 2 commits into
masterfrom
classname-enumerable

Conversation

@marvinhagemeister

@marvinhagemeister marvinhagemeister commented Jan 26, 2020

Copy link
Copy Markdown
Member

Our check if we should apply the className patch was wrong. It lead to already patched props being processed again on forceUpdate. At that point both class and className are defined, so className would always be marked as enumerable.

Fixes #2224.

@github-actions

github-actions Bot commented Jan 26, 2020 •
edited
Loading

Copy link
Copy Markdown

Size Change: -11 B (0%)

Total Size: 38.1 kB

Filename Size Change
compat/dist/compat.js 2.94 kB -3 B (0%)
compat/dist/compat.module.js 2.97 kB -4 B (0%)
compat/dist/compat.umd.js 2.99 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.08 kB 0 B
debug/dist/debug.module.js 3.07 kB 0 B
debug/dist/debug.umd.js 3.14 kB 0 B
devtools/dist/devtools.js 175 B 0 B
devtools/dist/devtools.module.js 185 B 0 B
devtools/dist/devtools.umd.js 252 B 0 B
dist/preact.js 3.69 kB 0 B
dist/preact.min.js 3.69 kB 0 B
dist/preact.module.js 3.71 kB 0 B
dist/preact.umd.js 3.75 kB 0 B
hooks/dist/hooks.js 1.06 kB 0 B
hooks/dist/hooks.module.js 1.08 kB 0 B
hooks/dist/hooks.umd.js 1.12 kB 0 B
test-utils/dist/testUtils.js 390 B 0 B
test-utils/dist/testUtils.module.js 392 B 0 B
test-utils/dist/testUtils.umd.js 469 B 0 B

compressed-size-action

@coveralls

coveralls commented Jan 26, 2020 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 99.807% when pulling 1b3dd5e on classname-enumerable into 14d8523 on master.

@JoviDeCroock JoviDeCroock merged commit cfaa1ca into master Jan 26, 2020
@JoviDeCroock JoviDeCroock deleted the classname-enumerable branch January 26, 2020 09:43
porfirioribeiro pushed a commit to porfirioribeiro/preact that referenced this pull request Feb 3, 2020
@marvinhagemeister @porfirioribeiro
Fix both class and className being enumerable (preactjs#2280)
d30c63a 
* Fix both class and className being enumerable

* Use loose equality (-1 B)
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

className is sometimes enumerable when it shouldn’t be

3 participants

@marvinhagemeister @coveralls @JoviDeCroock