Avoid removing existing dom nodes on subsequent replaceNode cal…#2274
Merged
Conversation
JoviDeCroock
commented
Jan 22, 2020
| } | ||
| } else if (newVNode !== oldVNode) { | ||
| if (excessDomChildren != null) { | ||
| excessDomChildren[excessDomChildren.indexOf(dom)] = null; |
Member
Author
There was a problem hiding this comment.
This mutates the array that is still referenced in diffChildren
84f64ad to
f2b8600
Compare
marvinhagemeister
approved these changes
Jan 23, 2020
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
That's a very good find! Can only imagine how much time it took to debug this 👍
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Feb 3, 2020
…actjs#2274) Avoid removing existing dom nodes on subsequent replaceNode calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2260
Fixes: #2264
We didn't correctly clean up existing nodes that weren't being replaced