Add test coverage for createElement#2273
Merged
JoviDeCroock merged 3 commits intoJan 22, 2020
Merged
Conversation
developit
approved these changes
Jan 22, 2020
developit
left a comment
Member
There was a problem hiding this comment.
Nice! These are great to have and will help make sure our memoization doesn't get tripped up by certain types of compiled JSX.
Member
|
Great first PR! Thanks @zubhav :) |
|
🚀 This PR has been merged! Once a new release is created, any changes will become available on npm. Until then, you can load and install it directly from the Pika CDN: |
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Feb 3, 2020
* Added test cases for when children param of createElement is unspecified or null * Assert that other props are still preserved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two tests for
createElement:childrenparameter is passed to the function asnullchildrenparameter is not passed to the function at allPS: Newbie to contributing