Fix failing IE test#2267
Merged
Merged
Conversation
IE will display falsy attribute as an empty string whereas other browsers will remove it completely. Only happens when innerHTML is used.
19efeb3 to
bddb13c
Compare
JoviDeCroock
approved these changes
Jan 21, 2020
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Feb 3, 2020
IE will display falsy attribute as an empty string whereas other browsers will remove it completely. Only happens when innerHTML is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by falsy attributes again which are rendered differently in IE's
innerHTML.