Add info for first time contributors#2265
Merged
Merged
Conversation
Member
|
Pavithra would be really glad about the impact!!! |
prateekbh
approved these changes
Jan 21, 2020
Member
Author
|
Commented on her tweet just minutes ago! Hope she sees it 🤞 |
Contributor
|
Great stuff! Although a lot was intuitive when I made a PR, this write up is great for diving into your first PR 😃 |
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a lot of missing information on how to contribute to Preact in
CONTRIBUTING.md👍 Based on the feedback from this excellent deep dive on youtube into our source code https://www.youtube.com/watch?v=0Uv6p-Etyqk 🎉