Upgrade devtools adapter to support Profiler#2246
Merged
Merged
Conversation
JoviDeCroock
approved these changes
Jan 16, 2020
JoviDeCroock
left a comment
Member
There was a problem hiding this comment.
Great work Marvin, do you mind removing the FLAKEY=false from our travisConfig?
cd178af to
9589e06
Compare
Member
Author
|
@JoviDeCroock
I'm a bit hesitant to remove them with this PR, because they are unrelated to devtools. |
Member
|
@marvinhagemeister, those work without Flakey last time I checked. Let’s push one commit to make sauce run for this PR then we can see (or we do it in a new PR after this one) |
Member
|
IIRC FLAKEY is only used for cross-browser tests via Saucelabs. Those tests should be running in CI against Chrome already. |
d0cd473 to
dc4ab43
Compare
dc4ab43 to
5243d01
Compare
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Feb 3, 2020
Upgrade devtools adapter to support Profiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the current devtools adapter with the one that is dynamically injected by the extension. This leads to a stark size reduction of
preact/debug😉Instead of just replacing the existing code in
preact/debug, this PR adds apreact/devtoolsub-package. The benefit of this is that it allows us to enable the devtools in production without bringing in the weight ofpreact/debug. The new devtools adapter weights just140 Balthough that size will likely be smaller once bundled into the main package.New features:
Tasks: