(fix) - replacing a node#1900
Merged
Merged
Conversation
…is is a combination between hydration and replacing a node we have a combination of excessDomChildren and dom which did not get cleared for the case of textNodes
marvinhagemeister
approved these changes
Aug 27, 2019
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
Ohh I like this one a lot 👍 👍 Really great work 💯
Member
|
Weird, GitHub seems to be bugging out for me. The |
Member
|
This fixes #1896 |
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Sep 3, 2019
* (tests) - add test for the replaceNode render case seemingly since this is a combination between hydration and replacing a node we have a combination of excessDomChildren and dom which did not get cleared for the case of textNodes * (fix) - clear excessDomChildren for the textNode case * (refactor) - save some bytes by inlining check and allocation
porfirioribeiro
pushed a commit
to porfirioribeiro/preact
that referenced
this pull request
Sep 3, 2019
* (tests) - add test for the replaceNode render case seemingly since this is a combination between hydration and replacing a node we have a combination of excessDomChildren and dom which did not get cleared for the case of textNodes * (fix) - clear excessDomChildren for the textNode case * (refactor) - save some bytes by inlining check and allocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.