Fix incorrect DOM when Fragment has siblings#1605
Closed
marvinhagemeister wants to merge 6 commits into
Closed
Conversation
d91f161 to
1ede951
Compare
This was referenced May 5, 2019
1ede951 to
8f52f12
Compare
developit
reviewed
May 6, 2019
| sibling = sibling._component && sibling._component._siblingVNode; | ||
| } | ||
|
|
||
| if (nextDom) { |
Member
There was a problem hiding this comment.
if it's smaller we could do:
parentDom.insertBefore(dom, nextDom || null);
Member
|
(Thinking out loud) I wonder if it would be smaller to just call Might require creating an intermediate Fragment like top-level |
andrewiggins
reviewed
May 8, 2019
| } | ||
|
|
||
| if (lastRendered && lastRendered._component) { | ||
| lastRendered._component._siblingVNode = childVNode; |
Member
There was a problem hiding this comment.
Could we add the _sibling pointer to the VNode? Would remove a check and a property access.
// children.js
if (lastRendered) {
lastRendered._sibling = childVNode;
}
lastRendered = childVNode;// component.js
let sibling = vnode._sibling;
while (sibling && !(nextDom = sibling._dom)) {
sibling = sibling._sibling;
}18f9445 to
c44a8c8
Compare
This was referenced Jun 6, 2019
Member
Author
|
Closing because #1689 is an improved version of this PR 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in #1593 and #1604 .
Currently a draft because it adds
+135+53 BEDIT: Didn't rebase against the savings in
masterwhen measuring size. Was way off 😅Also fixes: #1635