Order issue when setState changes vnode type in Fragment#1604
Closed
sventschui wants to merge 1 commit into
Closed
Order issue when setState changes vnode type in Fragment#1604sventschui wants to merge 1 commit into
sventschui wants to merge 1 commit into
Conversation
Member
|
This is an awesome test 👍 The error is caused by Will look into it later. |
Member
Author
|
Closing as the fix will land with #1605 |
Member
|
Let's keep this open until we land it, helps keep a clear overview. Great you're following up on things though :D Excuse me thought this was an issue and not a PR my bad 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test to showcase the ordering issue after setState when I was implementing #1593
As I don't have time to find a fix now I'll just open the PR with the test showcasing the bug. If nobody is faster than me I'll look into this tomorrow.