Get rid of top-level dependency on prop-types#1460
Merged
Conversation
It looks like this was inadvertantly added in preactjs@069bc8f#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R63 to support the debug app. Later it was properly added to the debug module itself via preactjs@109bdbd#diff-7a30b5ab41cde7241b4fc10f730143fdR23 but without cleaning it up from the main package.
marvinhagemeister
approved these changes
Mar 27, 2019
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
Good catch! You're completely right that the dependency can be removed 👍 🎉
Member
|
@marvinhagemeister Hmm does this work? The That being said, (if my understanding is correct) I'm not sure what to do here... |
Member
|
@andrewiggins that's a very good point! I'll check again later today |
Member
|
@andrewiggins yep, you're right. The CI didn't fail because I'll revert it. |
marvinhagemeister
added a commit
that referenced
this pull request
Mar 27, 2019
This reverts commit 6fac51e.
ForsakenHarmony
pushed a commit
that referenced
this pull request
Mar 28, 2019
Reverts #1460 I clicked the green button to early. As @andrewiggins correctly pointed out in #1460 we do need this for `preact/debug`. This wasn't caught by our CI because a `devDependency` pulled in `prop-types` too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this was inadvertently added in 069bc8f#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R63 when the debug app started using it.
Later it was properly added to the debug module itself via 109bdbd#diff-7a30b5ab41cde7241b4fc10f730143fdR23 but without cleaning it up from the main package.
This restores the
preactpackage itself to have no dependencies, so we can all sleep better at night.