Skip to content

Preact package should not have a hard dependency on prop-types #1496

@natevw

Description

@natevw

In 069bc8f#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R63 a new top-level dependency was added on prop-types@^15.6.2. This package in turn has three dependencies, one of which has an additional dependency of its own. So as a user I end up with six Other People's Codes on my machine (preact, prop-types, loose-envify, js-tokens, object-assign, react-is) even though I'm only using/needing/wanting one (preact).

The prop-types package itself is only needed by a "debug" sub-package hosted in this same repo, but the simple cleanup at #1460 was problematic and had to be reverted. Can a solution be found for the debug folder's usage that still gets us back to a place where preact itself has no dependencies?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions