chore: Update Github actions to latest versions#90
Merged
Conversation
Contributor
Author
|
@estherkim Did you previous PR solve your deprecation warning? |
Contributor
Author
|
@developit @JoviDeCroock Please review? |
Member
|
Are you seriously tagging me for something you just opened? |
Contributor
Author
I don't know who reviews changes in this repo. You approved the last PR that was supposed to resolve this issue so you seemed like a likely candidate? Sorry if I broke some protocol. |
Member
|
Tagging people is generally a way to get attention if something has gone unnoticed for a while. Most of us have some sort of notifications set up and will get to things eventually. So tagging specific people for a review less than 10 minutes after opening can be seen as a bit rude in any OSS project, as maintaining this stuff isn't our day job or anything we're really paid for. It's something we do in our free time, when we can. It comes off as a bit demanding, which is what I think Jovi was hinting at. Rest assured, someone will take a look eventually. |
JoviDeCroock
approved these changes
Apr 23, 2023
renovate Bot
referenced
this pull request
in UI5/webcomponents-react
Apr 23, 2024
…5748) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [preactjs/compressed-size-action](https://togithub.com/preactjs/compressed-size-action) | action | minor | `2.5.0` -> `2.6.0` | --- ### Release Notes <details> <summary>preactjs/compressed-size-action (preactjs/compressed-size-action)</summary> ### [`v2.6.0`](https://togithub.com/preactjs/compressed-size-action/releases/tag/2.6.0) [Compare Source](https://togithub.com/preactjs/compressed-size-action/compare/2.5.0...2.6.0) #### New Features / Improvements - \[feature] Add install script inputs by [@​jeffreys-cat](https://togithub.com/jeffreys-cat) in [https://github.com/preactjs/compressed-size-action/pull/85](https://togithub.com/preactjs/compressed-size-action/pull/85) - feat: Add support for more precise percentage changes by [@​mister-ben](https://togithub.com/mister-ben) in [https://github.com/preactjs/compressed-size-action/pull/97](https://togithub.com/preactjs/compressed-size-action/pull/97) - Add support for Bun by [@​jack-weilage](https://togithub.com/jack-weilage) in [https://github.com/preactjs/compressed-size-action/pull/104](https://togithub.com/preactjs/compressed-size-action/pull/104) #### Action Maintenance - Update action.yml to use node16 by [@​estherkim](https://togithub.com/estherkim) in [https://github.com/preactjs/compressed-size-action/pull/87](https://togithub.com/preactjs/compressed-size-action/pull/87) - Move to node20, release v3 by [@​jonny-puma](https://togithub.com/jonny-puma) in [https://github.com/preactjs/compressed-size-action/pull/103](https://togithub.com/preactjs/compressed-size-action/pull/103) #### Repo Maintenance - Fix typo by [@​denniskigen](https://togithub.com/denniskigen) in [https://github.com/preactjs/compressed-size-action/pull/86](https://togithub.com/preactjs/compressed-size-action/pull/86) - chore: Update Github actions to latest versions by [@​mmckenziedev](https://togithub.com/mmckenziedev) in [https://github.com/preactjs/compressed-size-action/pull/90](https://togithub.com/preactjs/compressed-size-action/pull/90) - chore: Bump package-lock.json by [@​rschristian](https://togithub.com/rschristian) in [https://github.com/preactjs/compressed-size-action/pull/105](https://togithub.com/preactjs/compressed-size-action/pull/105) #### New Contributors - [@​denniskigen](https://togithub.com/denniskigen) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/86](https://togithub.com/preactjs/compressed-size-action/pull/86) - [@​estherkim](https://togithub.com/estherkim) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/87](https://togithub.com/preactjs/compressed-size-action/pull/87) - [@​mmckenziedev](https://togithub.com/mmckenziedev) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/90](https://togithub.com/preactjs/compressed-size-action/pull/90) - [@​jack-weilage](https://togithub.com/jack-weilage) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/104](https://togithub.com/preactjs/compressed-size-action/pull/104) - [@​jonny-puma](https://togithub.com/jonny-puma) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/103](https://togithub.com/preactjs/compressed-size-action/pull/103) - [@​mister-ben](https://togithub.com/mister-ben) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/97](https://togithub.com/preactjs/compressed-size-action/pull/97) - [@​jeffreys-cat](https://togithub.com/jeffreys-cat) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/85](https://togithub.com/preactjs/compressed-size-action/pull/85) - [@​rschristian](https://togithub.com/rschristian) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/105](https://togithub.com/preactjs/compressed-size-action/pull/105) **Full Changelog**: preactjs/compressed-size-action@2.5.0...2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
sarayourfriend
pushed a commit
to sarayourfriend/compressed-size-action
that referenced
this pull request
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Github actions
actions/checkout@v2andactions/setup-node@v1need to be updated to the latest versions to be in compliance with Github's node@12 deprecation. I believe the following warning is due to these actions being out of date.I don't think #87 fully solved this problem
From the link:
In my own projects I updated these actions to the latest major versions and the deprecation warning went away.
I imagine this change would be a major version upgrade as I had to add these new versions to my project's allowed list of actions, otherwise I receive this warning and the actions fail to execute.