[feature] Add install script inputs#85
Merged
Merged
Conversation
|
also have a need for this, would like to run Is this a suitable solution @developit? |
Closed
Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com>
rschristian
approved these changes
Apr 22, 2024
rschristian
left a comment
Member
There was a problem hiding this comment.
Cheers, sorry for the long time without any eyes on this
rschristian
reviewed
Apr 22, 2024
renovate Bot
referenced
this pull request
in UI5/webcomponents-react
Apr 23, 2024
…5748) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [preactjs/compressed-size-action](https://togithub.com/preactjs/compressed-size-action) | action | minor | `2.5.0` -> `2.6.0` | --- ### Release Notes <details> <summary>preactjs/compressed-size-action (preactjs/compressed-size-action)</summary> ### [`v2.6.0`](https://togithub.com/preactjs/compressed-size-action/releases/tag/2.6.0) [Compare Source](https://togithub.com/preactjs/compressed-size-action/compare/2.5.0...2.6.0) #### New Features / Improvements - \[feature] Add install script inputs by [@​jeffreys-cat](https://togithub.com/jeffreys-cat) in [https://github.com/preactjs/compressed-size-action/pull/85](https://togithub.com/preactjs/compressed-size-action/pull/85) - feat: Add support for more precise percentage changes by [@​mister-ben](https://togithub.com/mister-ben) in [https://github.com/preactjs/compressed-size-action/pull/97](https://togithub.com/preactjs/compressed-size-action/pull/97) - Add support for Bun by [@​jack-weilage](https://togithub.com/jack-weilage) in [https://github.com/preactjs/compressed-size-action/pull/104](https://togithub.com/preactjs/compressed-size-action/pull/104) #### Action Maintenance - Update action.yml to use node16 by [@​estherkim](https://togithub.com/estherkim) in [https://github.com/preactjs/compressed-size-action/pull/87](https://togithub.com/preactjs/compressed-size-action/pull/87) - Move to node20, release v3 by [@​jonny-puma](https://togithub.com/jonny-puma) in [https://github.com/preactjs/compressed-size-action/pull/103](https://togithub.com/preactjs/compressed-size-action/pull/103) #### Repo Maintenance - Fix typo by [@​denniskigen](https://togithub.com/denniskigen) in [https://github.com/preactjs/compressed-size-action/pull/86](https://togithub.com/preactjs/compressed-size-action/pull/86) - chore: Update Github actions to latest versions by [@​mmckenziedev](https://togithub.com/mmckenziedev) in [https://github.com/preactjs/compressed-size-action/pull/90](https://togithub.com/preactjs/compressed-size-action/pull/90) - chore: Bump package-lock.json by [@​rschristian](https://togithub.com/rschristian) in [https://github.com/preactjs/compressed-size-action/pull/105](https://togithub.com/preactjs/compressed-size-action/pull/105) #### New Contributors - [@​denniskigen](https://togithub.com/denniskigen) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/86](https://togithub.com/preactjs/compressed-size-action/pull/86) - [@​estherkim](https://togithub.com/estherkim) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/87](https://togithub.com/preactjs/compressed-size-action/pull/87) - [@​mmckenziedev](https://togithub.com/mmckenziedev) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/90](https://togithub.com/preactjs/compressed-size-action/pull/90) - [@​jack-weilage](https://togithub.com/jack-weilage) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/104](https://togithub.com/preactjs/compressed-size-action/pull/104) - [@​jonny-puma](https://togithub.com/jonny-puma) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/103](https://togithub.com/preactjs/compressed-size-action/pull/103) - [@​mister-ben](https://togithub.com/mister-ben) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/97](https://togithub.com/preactjs/compressed-size-action/pull/97) - [@​jeffreys-cat](https://togithub.com/jeffreys-cat) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/85](https://togithub.com/preactjs/compressed-size-action/pull/85) - [@​rschristian](https://togithub.com/rschristian) made their first contribution in [https://github.com/preactjs/compressed-size-action/pull/105](https://togithub.com/preactjs/compressed-size-action/pull/105) **Full Changelog**: preactjs/compressed-size-action@2.5.0...2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
sarayourfriend
pushed a commit
to sarayourfriend/compressed-size-action
that referenced
this pull request
Sep 27, 2024
* [feature] Add install script inputs * docs: Add docs for new `install-script` option Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> * Update action.yml --------- Co-authored-by: Ryan Christian <rchristian@ryanchristian.dev> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We install dependencies with NPM install, Action's
installScriptnpm cineeds a package-lock.json file, otherwise will throw an error. But in some cases, the library useoptionalDependencies, package-lock.json is different on different platforms.For example, vercel's turborepo，I run
npm installon my MAC and create a package-lock.json, but onlyturbo-darwin-arm64exist in package-lock.json, while pushed it to GitHub and run this Action, becauseturbo-linux-64needs on Linux. Then I got an error. I need to use a custom install methodnpm install --no-package-lockto make it works.I would like to add an installScript to support custom installation scripts like buildScript.