Skip to content

use the shuffle method of Random instead #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asottile merged 1 commit into from
May 31, 2020
Merged

use the shuffle method of Random instead #1480

asottile merged 1 commit into from
May 31, 2020

Conversation

@asottile
Copy link
Member

@asottile asottile commented May 31, 2020

resolves #1479

asottile
asottile commented May 31, 2020
View reviewed changes
pre_commit/languages/helpers.py
from typing import NoReturn

FIXED_RANDOM_SEED = 1542676186
FIXED_RANDOM_SEED = 1542676187
Copy link
Member Author

@asottile asottile May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to keep a few 50/50 tests passing -- the switch from random= to not also changed the ordering

@asottile asottile merged commit 79359ed into master May 31, 2020
@asottile asottile deleted the random_meth branch May 31, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

random.shuffle's random= argument got deprecated

2 participants

@asottile