Fixed get_native_singleton retuning nullptr.#775
Merged
praydog merged 1 commit intopraydog:native-singleton-fixfrom May 5, 2023
Merged
Fixed get_native_singleton retuning nullptr.#775praydog merged 1 commit intopraydog:native-singleton-fixfrom
praydog merged 1 commit intopraydog:native-singleton-fixfrom
Conversation
praydog
added a commit
that referenced
this pull request
May 5, 2023
* Fixed get_native_singleton retuning nullptr. (#775) * Style adjustments and only use REType version as a fallback --------- Co-authored-by: DanteSSS333 <53407669+DanteSSS333@users.noreply.github.com>
dtlnor
pushed a commit
to dtlnor/REFramework
that referenced
this pull request
Sep 12, 2024
* Fixed get_native_singleton retuning nullptr. (praydog#775) * Style adjustments and only use REType version as a fallback --------- Co-authored-by: DanteSSS333 <53407669+DanteSSS333@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some native singletons (like via.gui.GUIManager) do not have a RETypeDef, only a REType. get_native_singleton failed for them due to looking for a RETypeDef.