Expose keypair_derand in liboqs integration YML#886
Merged
mkannwischer merged 1 commit intopq-code-package:sw-liboqs-derandfrom Mar 21, 2025
Merged
Expose keypair_derand in liboqs integration YML#886mkannwischer merged 1 commit intopq-code-package:sw-liboqs-derandfrom
mkannwischer merged 1 commit intopq-code-package:sw-liboqs-derandfrom
Conversation
69a5cee to
81fb1c5
Compare
2 tasks
Contributor
|
@SWilson4 will you give us a ping when this is ready? |
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
81fb1c5 to
e70e67e
Compare
Contributor
Author
|
@hanno-becker @mkannwischer open-quantum-safe/liboqs#2070 has landed, so this is ready to go. |
mkannwischer
approved these changes
Mar 21, 2025
75eb0d4
into
pq-code-package:sw-liboqs-derand
121 checks passed
mkannwischer
added a commit
that referenced
this pull request
Apr 2, 2025
This updates liboqs to the most recent commit in main: https://github.com/open-quantum-safe/liboqs/tree/6337a8424deae09aa835ddd920faff83a8f0e1d7 open-quantum-safe/liboqs#2070 reintroduced patching for mlkem-native to expose the keypair_derand functions. This patching is no longer needed since #886 got merged. This commit hence adds to the liboqs test in CI the removal of the patch in the copy_from_upstream.yml. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
mkannwischer
added a commit
that referenced
this pull request
Apr 2, 2025
This updates liboqs to the most recent commit in main: https://github.com/open-quantum-safe/liboqs/tree/6337a8424deae09aa835ddd920faff83a8f0e1d7 open-quantum-safe/liboqs#2070 reintroduced patching for mlkem-native to expose the keypair_derand functions. This patching is no longer needed since #886 got merged. This commit hence adds to the liboqs test in CI the removal of the patch in the copy_from_upstream.yml. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updates liboqs integration YML files to enable open-quantum-safe/liboqs#2070. Keeping as draft until that PR lands in case of changes.
Steps:
N/A
Performed local tests:
lintpassingtests allpassingtests benchpassingtests cbmcpassingDo you expect this change to impact performance: No
If yes, please provide local benchmarking results.