Use basic-auth module for parsing#62
Closed
dougwilson wants to merge 1 commit intopouchdb:masterfrom
dougwilson:basic-auth
Closed
Use basic-auth module for parsing#62dougwilson wants to merge 1 commit intopouchdb:masterfrom dougwilson:basic-auth
dougwilson wants to merge 1 commit intopouchdb:masterfrom
dougwilson:basic-auth
Conversation
nolanlawson
pushed a commit
that referenced
this pull request
Jul 27, 2014
Contributor
|
This is one of those annoying cases where we haven't automated the tests. But I tested manually with credentials and everything looks golden. Nice work, thanks! |
Contributor
Author
Yea, I thought the same thing when I purposely broke it and saw all the tests passed, so I knew I had to manually test it :( |
Contributor
|
Yeah, in the future we're hoping the |
garrensmith
pushed a commit
that referenced
this pull request
Feb 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought you may like this since it simplified your code quite a bit. It's not necessary, though :)