Fix epbs consensus spec to be executable#10
Merged
Conversation
e0a555e to
4952cd0
Compare
c8ca26f to
c732be9
Compare
acfb8fd to
ad4e0f0
Compare
potuz
requested changes
Jun 27, 2024
potuz
left a comment
Owner
There was a problem hiding this comment.
There are a lot of places where the type should be the original Python bool and not an SSZ type boolean
|
|
||
| ### New `ChildNode` | ||
| Auxiliary class to consider `(block, slot, bool)` LMD voting | ||
| Auxiliary class to consider `(block, slot, boolean)` LMD voting |
| root: Root | ||
| slot: Slot | ||
| is_payload_present: bool | ||
| is_payload_present: boolean |
| ptc_vote: Dict[Root, Vector[uint8, PTC_SIZE]] = field(default_factory=dict) # [New in EIP-XXXX] | ||
| payload_withhold_boost_root: Root # [New in EIP-XXXX] | ||
| payload_withhold_boost_full: bool # [New in EIP-XXXX] | ||
| payload_withhold_boost_full: boolean # [New in EIP-XXXX] |
bdba086 to
f960d31
Compare
potuz
pushed a commit
that referenced
this pull request
Jul 8, 2024
Fix epbs consensus spec to be executable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several bugs in
specs/_features/epbs/beacon-chain.md:state.previous_inclusion_listusages inprocess_execution_payloadBitVectortoBitvectorboolwithbooleanAs a result, ePBS should be executable via
make pyspec. The execution files should be located intests/core/pyspec/eth2spec/epbs, which I won't check in.