This repository was archived by the owner on Jan 2, 2021. It is now read-only.
Default to empty string if data values not defined.#52
Merged
potomak merged 1 commit intopotomak:masterfrom Jun 15, 2014
Merged
Default to empty string if data values not defined.#52potomak merged 1 commit intopotomak:masterfrom
potomak merged 1 commit intopotomak:masterfrom
Conversation
potomak
added a commit
that referenced
this pull request
Jun 15, 2014
Default to empty string if data values not defined.
Owner
|
Thanks. I'm going to release it tomorrow. |
potomak
added a commit
that referenced
this pull request
Jun 19, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was adding this plugin to a site with jQuery 1.7 and authentication with Instagram was failing as the string "null" was being passed as the OAuth token (due to this jQuery bug).
Can understand if you're not worried about supporting older versions of jQuery, but this minor change makes the plugin work out of the box with jQuery 1.7 without affecting any other functionality.