Replace double-quotes by single-quotes in codegen/php-curl#352
Merged
Replace double-quotes by single-quotes in codegen/php-curl#352
Conversation
Contributor
|
Can you add a newman test/ unit test with |
This is to verify that having a string of type $name is interpreted correctly by php in the generated code.
umeshp7
approved these changes
Oct 20, 2020
This was referenced Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #284
PHP expands variables and escape sequences for special characters inside double-quotes. This is a problem if body of a request contains
$sign. Using single-quotes solves this problem. This is an alternative solution to #285 .