Adding '\' before a valid PHP variable name solves #284#285
Closed
5xdev wants to merge 1 commit intopostmanlabs:developfrom
Closed
Adding '\' before a valid PHP variable name solves #284#2855xdev wants to merge 1 commit intopostmanlabs:developfrom
5xdev wants to merge 1 commit intopostmanlabs:developfrom
Conversation
Adding '\' before a valid PHP variable name in the request URL (finalUrl)
|
Instead of escaping |
Contributor
|
Fixed by #352. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #284
Why my solution works :-
My solution is very simple and straight forward, I am just replacing the occurrence of a valid PHP URL with '\' added at the begning. I have tested this code with various test cases and it is working flawlessly.