Skip to content

Fix maven issues while downloading java dependencies#171

Merged
umeshp7 merged 4 commits intodevelopfrom
feature/fix-ci-issues
Mar 1, 2020
Merged

Fix maven issues while downloading java dependencies#171
umeshp7 merged 4 commits intodevelopfrom
feature/fix-ci-issues

Conversation

@umeshp7
Copy link
Contributor

@umeshp7 umeshp7 commented Feb 24, 2020

central.maven.org is moved to https://repo1.maven.org.
This is causing CI to fail.
Fixes #179

@manjots1607
Copy link

@umeshp7 and @shreys7 I also worked on this issue and working to find root cause of timeout of "follow redirects" in ok-http for that I need to run the test locally but unable to do so.
I couldn't figure out why "npm test" command is not running.

Can You List All the steps needed to take before running npm test command locally

@nikhilmuz
Copy link
Contributor

Not noticed this thus submitted duplicate PR #187 BTW my observations:

  • 100 seconds works fine.
  • I am not sure, whether including zip is better or just changing repo URL for maven dependencies is good enough. I think including zip will cause an increase in repo size unnecessarily.

@nikhilmuz
Copy link
Contributor

@manjots1607 it requires jar dependencies for okhttp to work. see ci requirements bash file for the list of dependencies required before running tests locally.

@umeshp7
Copy link
Contributor Author

umeshp7 commented Mar 1, 2020

@nikhilmuz
Using repo1.maven.org is not a good idea since that could also change without notice (this name seems temporary too).
It does increase the repo size but it's a one time expense. We could find a better solution in the future, with specific test environments for each code-gen for more rigorous tests.

Also, increasing timeout time does not solve the primary issue. The time it is taking to finish execution could be a problem with the code we have generated. The aim is not to pass the test, but to produce accurate code-snippets.
I am trying a fix with mockbin's request, hope that works since I don't see any issues with the java-okhttp code-generated for redirects.

@manjots1607 Please refer to the contributing guide, hit us up if need more clarification in that.

@umeshp7 umeshp7 requested a review from shreys7 March 1, 2020 13:12
@umeshp7 umeshp7 merged commit d460aaa into develop Mar 1, 2020
nikhilmuz pushed a commit to nikhilmuz/postman-code-generators that referenced this pull request Mar 2, 2020
* Zip java-okhttp dependencies and unzip in ci-requirements

* zip java-unirest dependencies and update ci-requirements.

* Change httpbin to mockbin for redirect test.
@umeshp7 umeshp7 deleted the feature/fix-ci-issues branch October 9, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build on Travis CI failing on most of PR's

4 participants