Conversation
|
My apologies for my slowness here; I've been quite busy, and haven't had time to review your PRs as promptly as I'd wish.
We'll just ship a major release, and people can deal with any incompatibilities.
Can you elaborate on this further? |
…ous-antelope-d8443985a8
This package also supports a few non-standard features.
I personally tend to favor standard/specification defined behavior when creating and updating packages like these. But I want to be respectful of all current users. Having two packages, each with a different focus can be a good alternative. As far as I can tell these changes aren't breaking except for extreme edge cases, but I try to be mindful of my blindspots. |
…ous-antelope-d8443985a8
…-83e8ca9693' into wip-rewrite--courteous-antelope-d8443985a8
…8a06ed7a' into wip-rewrite--courteous-antelope-d8443985a8
…9d8d0' into wip-rewrite--courteous-antelope-d8443985a8
…ent-water-buffalo-15479099b8' into wip-rewrite--courteous-antelope-d8443985a8
…ous-antelope-d8443985a8
…ous-antelope-d8443985a8
…ous-antelope-d8443985a8
…ous-antelope-d8443985a8
@RyanZim this set of changes is roughly where I want to end up.
It combines #531 and #530 and fixes a lot of previously unknown bugs.
It is validated by comparing the behavior against Firefox https://github.com/romainmenke/css-import-tests
Summary:
@mediarules into a single rule (this was broken)@layerrules into a single rule (this was broken)@supportsskipDuplicatesis false@importswith relative urls (this must not work, and previously did, this should affect no one)If this change does go through it would make
postcss-importvastly superior tolightningcss,esbuild, ... which would be a nice incentive for those packages to fix their issues.This is a very large rewrite however and I am unsure if it makes sense to ship this here.
I can not foresee if people depended in weird ways on behavior that, to me, is a bug.
An alternative I am considering is to strip down some of the features and create a new plugin that is more focussed on matching
@importas it works in browsers.thoughts?