You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fully implementing supports conditions will require a fairly large refactor and the codebase is already very complex.
I would like to first do a few refactors.
This is one of them.
I've added c8 to ensure that test coverage remains high throughout this process.
File
% Stmts
% Branch
% Funcs
% Lines
Uncovered Line #s
All files
100
99.65
100
100
postcss-import
100
100
100
100
index.js
100
100
100
100
postcss-import/lib
100
99.34
100
100
assign-layer-names.js
100
100
100
100
data-url.js
100
100
100
100
join-layer.js
100
100
100
100
join-media.js
100
100
100
100
load-content.js
100
100
100
100
parse-statements.js
100
100
100
100
process-content.js
100
93.75
100
100
26
resolve-id.js
100
100
100
100
Initially the parsing algorithm was a simple split:
look for anything that could be a uri
everything after is a media condition
With layer and supports something more flexible is needed.
I've changed the parsing algorithm to a loop that keeps track of what has been encountered and errors on any unexpected sequences.
Any supports conditions will give errors:
Supports conditions are not implemented at this time.
This is a behavior change.
Before this PR supports conditions would be treated as if they were media conditions, which is also incorrect.
Both behaviors are "broken" but after this change CSS authors will receive more meaningful feedback.
@romainmenke are you thinking we should release with this warning for @supports, or is this just a temporary measure until we add support after refactoring?
are you thinking we should release with this warning for @supports, or is this just a temporary measure until we add support after refactoring?
I am hoping it is temporary.
But I want to keep the code base healthy after each change and I would like to keep each change small-ish.
The state in this pull request is something that can be released if needed.
I plan to continue work towards full support for supports conditions, but this could take a while. It really complicates things that four different types of rules interact (import, media, layer, supports). With layer I was able to patch a few existing bits and make it work, but a larger refactor is needed for supports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RyanZim
left a comment
see : #529
supportsconditionsFully implementing supports conditions will require a fairly large refactor and the codebase is already very complex.
I would like to first do a few refactors.
This is one of them.
I've added
c8to ensure that test coverage remains high throughout this process.Initially the parsing algorithm was a simple split:
mediaconditionWith
layerandsupportssomething more flexible is needed.I've changed the parsing algorithm to a loop that keeps track of what has been encountered and errors on any unexpected sequences.
Any
supportsconditions will give errors:This is a behavior change.
Before this PR
supportsconditions would be treated as if they weremediaconditions, which is also incorrect.Both behaviors are "broken" but after this change CSS authors will receive more meaningful feedback.