Skip to content

Fix ::file-selector-button pseudo-element#1420

Merged
ai merged 1 commit intopostcss:mainfrom
usmanyunusov:fix-1419
Aug 21, 2021
Merged

Fix ::file-selector-button pseudo-element#1420
ai merged 1 commit intopostcss:mainfrom
usmanyunusov:fix-1419

Conversation

@usmanyunusov
Copy link
Contributor

@ai ai merged commit e47f86b into postcss:main Aug 21, 2021
@XhmikosR
Copy link

@ai I think this introduced ::-moz-file-selector-button which is invalid/never implemented.

@ai
Copy link
Member

ai commented Aug 24, 2021

@XhmikosR can you send PR to block usage of -moz-?

@XhmikosR
Copy link

Unsure where to look for, I'm not familiar with the codebase :/

@ai
Copy link
Member

ai commented Aug 24, 2021

@usmanyunusov can you add text for Firefox and prevent wrong prefix generation?

@usmanyunusov
Copy link
Contributor Author

@ai, I'll see the error

@usmanyunusov
Copy link
Contributor Author

@ai, PR: #1421

@usmanyunusov
Copy link
Contributor Author

usmanyunusov commented Aug 25, 2021

Why only these browsers? - https://github.com/postcss/autoprefixer/blob/main/data/prefixes.js#L528
And if the firefox 90?

@ai
Copy link
Member

ai commented Aug 25, 2021

Why only these browsers?

We copied data from MDN to avoid adding new dependency and since new browsers will not have prefix

@ai
Copy link
Member

ai commented Aug 26, 2021

@XhmikosR the second fix was released in 10.3.3

@XhmikosR
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants