Added blocker -moz- for ::file-selector-button#1421
Merged
ai merged 3 commits intopostcss:mainfrom Aug 26, 2021
usmanyunusov:fix-1419-2
Merged
Added blocker -moz- for ::file-selector-button#1421ai merged 3 commits intopostcss:mainfrom usmanyunusov:fix-1419-2
ai merged 3 commits intopostcss:mainfrom
usmanyunusov:fix-1419-2
Conversation
Member
|
We also need to change tests. We need a TDD here:
You may need to use another browsers in the test. |
Contributor
Author
|
@ai, Replaced the test: let fileSelectorButtoner = autoprefixer({
overrideBrowserslist: ['Chrome > 25', 'Firefox >= 82']
})Test fail: @@ -1,22 +1,34 @@
::-webkit-file-upload-button {
background: black
}
+ ::-moz-file-selector-button {
+ background: black
+ }
+
::file-selector-button {
background: black
}
input::-webkit-file-upload-button {
color: black;
}
- input::file-selector-button {
+ input::-moz-file-selector-button {
color: black;
}
- input:hover::-webkit-file-upload-button {
+ input::file-selector-button {
+ color: black;
+ }
+
+ input:hover::-webkit-file-upload-button {
+ color: white;
+ }
+
+ input:hover::-moz-file-selector-button {
color: white;
}
input:hover::file-selector-button {
color: white; |
Member
|
Send test changes to PR |
Contributor
Author
|
I suggest replacing all prefixes with a class FileSelectorButton extends Selector {
constructor(name, prefixes, all) {
super(name, prefixes, all)
if (this.prefixes) {
this.prefixes = utils.uniq(
this.prefixes.map(i => {
return '-webkit-'
})
)
}
} |
Member
|
Yeap, let’s try. |
Member
|
The fix was released in 10.3.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.