Remove line breaks issue#109#111
Merged
devblackops merged 4 commits intoposhbotio:masterfrom Oct 6, 2018
AndrewPla:RemoveLineBreaks-Issue#109
Merged
Remove line breaks issue#109#111devblackops merged 4 commits intoposhbotio:masterfrom AndrewPla:RemoveLineBreaks-Issue#109
devblackops merged 4 commits intoposhbotio:masterfrom
AndrewPla:RemoveLineBreaks-Issue#109
Conversation
Switched to using the command parser to determine if a message is a command
This reverts commit 485ac52.
…ommand The $firstword contained whitespace that caused the command to fail isbotcommand. We switched to using the parsed command, which trims the whitespace.
devblackops
reviewed
Sep 14, 2018
Contributor
Author
|
Yeah, I must've mucked it up at some point when creating the new branch and
what not. Whoopsie!
|
The command is contained inside the command property so now the -match will evaluate properly.
Member
|
Thanks @AndrewPla! |
devblackops
added a commit
that referenced
this pull request
Oct 26, 2018
#111 broke the ability to run a command by the fully qualified command name <plugin>:<commandname>:<version> by only testing the command name against the possible command prefixes. This reverts that behavior and tests the first word of the message string but also ensures CRLF is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to using the command parser to determine if a message is a bot command or not.
Description
Related Issue
Issue #109
How Has This Been Tested?
It's a small change, but it has fixed my issue. There may be a different way of handling this, but I see that the $parsedCommand is referred to in a few other places so I think it matches with the style.
Types of changes
Checklist: