added an interface for reader factories#63
Merged
ddeboer merged 1 commit intoportphp:masterfrom Nov 4, 2017
Merged
Conversation
Member
|
Thanks! |
ddeboer
reviewed
Nov 4, 2017
| @@ -0,0 +1,20 @@ | |||
| <?php | |||
|
|
|||
| namespace Port\Csv; | |||
ddeboer
added a commit
to portphp/excel
that referenced
this pull request
Nov 4, 2017
ddeboer
added a commit
to portphp/dbal
that referenced
this pull request
Nov 4, 2017
ddeboer
added a commit
to portphp/csv
that referenced
this pull request
Nov 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this would allow us to type hint this interface, rather than the
CsvReaderFactorymaking the class useable for all other file types:https://github.com/solutionDrive/SyliusImportExportPlugin/blob/master/src/Importer/AbstractImporter.php#L39
Obviously all the reader factories would then need to implement this interface.