refresh the attrs more often in basic shaping#202
Merged
jackpot51 merged 1 commit intopop-os:mainfrom Nov 17, 2023
Merged
Conversation
jackpot51
approved these changes
Nov 17, 2023
StewartCanva
pushed a commit
to StewartCanva/cosmic-text
that referenced
this pull request
Jun 26, 2025
refresh the attrs more often in basic shaping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed when trying to migrate to cosmic-text in bevy, the colors was not updated correctly when using Shaping::Basic