Fix alignment when using Wrap::None#131
Merged
jackpot51 merged 1 commit intopop-os:mainfrom Jun 8, 2023
Merged
Conversation
79cd8ee to
8d37da5
Compare
15 tasks
StewartCanva
pushed a commit
to StewartCanva/cosmic-text
that referenced
this pull request
Jun 26, 2025
Fix alignment when using `Wrap::None`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130
Some review of this would be a good idea as I am unfamiliar with cosmic-text's codebase, and just pattern matched the fix based on the description on the problem in #130 ("the
wproperty ofVisualLineis not updated"), and looking at how this was handled in the surrounding code for the otherWrapconfigurations. However it is verified as actually fixing #130 in Vizia.