Allow creating a Buffer with no FontSystem#127
Merged
jackpot51 merged 2 commits intopop-os:mainfrom Jun 9, 2023
Merged
Conversation
jackpot51
previously approved these changes
Jun 8, 2023
Member
|
This now has conflicts after #122 |
98cfc86 to
2ed9c34
Compare
Contributor
Author
|
I've resolved the conflict. |
jackpot51
approved these changes
Jun 9, 2023
15 tasks
StewartCanva
pushed a commit
to StewartCanva/cosmic-text
that referenced
this pull request
Jun 26, 2025
Allow creating a `Buffer` with no `FontSystem`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This introduces a new constructor
Buffer::new_emptywhich has zeroBufferLines and is unshaped.Buffer::newcallsBuffer::new_empty.Context
#97 untangled the
Bufferfrom theFontSystem, but didn't remove the need to pass aFontSystemintoBuffer::new.It is useful to be able to initialise a
Bufferwhen you don't have aFontSystemin scope, for example if you want toimpl Defaultfor some type that contains aBuffer, since it is otherwise constructable without aFontSystem:Future work
Any of the examples where
Buffer::newis called and then immediately overwritten throughBuffer::set_textor overwriting theBufferLines could be rewritten in terms ofBuffer::new_emptybut I have not done this.